[CRIU] [PATCH 2/2] make: protobuf -- Fix building, v3

[Ruslan Kuprieiev]

Hi Filipe,

Removing $(obj)/opts.pb-c.c still leaves race conditions somewhere,
as result of make -j N is not consistent... =(

On 01/21/2015 07:39 AM, Filipe Brandenburger wrote:
> This is still not fixing the build for me...
>
> I just tried this patch on top of 97743f421c6557 and building from a
> clean tree results in:
>
>    PB DDEP  protobuf/stats.proto.d
>    PB DEP   protobuf/stats.proto.c.d
> make[1]: Leaving directory `/usr/local/google/home/filbranden/devel/criu'
> make[1]: Entering directory `/usr/local/google/home/filbranden/devel/criu'
> make[1]: Circular protobuf/opts.pb-c.c <- protobuf/opts.pb-c.c
> dependency dropped.
> make[1]: *** No rule to make target
> `protobuf/google.pb-c.cbuf/descriptor.proto', needed by
> `protobuf/opts.pb-c.c'.  Stop.
> make[1]: Leaving directory `/usr/local/google/home/filbranden/devel/criu'
> make: *** [protobuf] Error 2
>
> What seems to be fixing it for me is to remove $(obj)/opts.pb-c.c from
> the $(obj)/%.pb-c.c rule introduced in the 97743f421c6557 commit,
> since essentially this creates a dependency on itself to build
> opts.pb-c.c...
>
> I'll send a patch for it shortly.
>
> Cheers,
> Filipe
> _______________________________________________
> CRIU mailing list
> CRIU at openvz.org
> https://lists.openvz.org/mailman/listinfo/criu