[CRIU] [PATCH] make: fix multithreded compilation

Pavel Emelyanov xemul at parallels.com
Tue Jan 20 06:42:01 PST 2015


On 01/20/2015 05:14 PM, Cyrill Gorcunov wrote:
> On Tue, Jan 20, 2015 at 04:53:15PM +0300, Pavel Emelyanov wrote:
>>> --- a/Makefile
>>> +++ b/Makefile
>>> @@ -148,7 +148,9 @@ ifeq ($(GCOV),1)
>>>  %.o $(PROGRAM): override CFLAGS += --coverage
>>>  endif
>>>  
>>> -all: config pie $(VERSION_HEADER) $(CRIU-LIB) $(PROGRAM) crit
>>> +all: config pie $(VERSION_HEADER) $(CRIU-LIB)
>>> +	$(Q) $(MAKE) $(PROGRAM)
>>> +	$(Q) $(MAKE) crit
>>
>> Is this change really needed? AFAIU the problem is that some .proto
>> files depend on opts.proto and in case the former gets compiled
>> before the latter we're in trouble. And it doesn't (shouldn't) matter
>> whether we compile criu or crit first.
>>
>> Cyrill?
> 
>>From a glance, hard to tell, we've had a conversation with Ruslan yesterday,
> while his patch fixes the problem, pick it up please, I'll cleanup the
> things tonight.
> .
> 

OK, applied.


More information about the CRIU mailing list