[CRIU] [PATCH 0/7] CRiu Image Tool(crit), v4

Pavel Emelyanov xemul at parallels.com
Tue Jan 13 10:30:13 PST 2015


On 01/13/2015 09:22 PM, Ruslan Kuprieiev wrote:
> 
> On 01/13/2015 08:10 PM, Pavel Emelyanov wrote:
>>>> Is it technically possible to make the json text look like this:
>>>>
>>>>    {
>>>>         "magic": "REG_FILES",
>>>>         "entries": [
>>>>             {
>>>>                 "foo": "1",
>>>>                 "bar": "BAR",
>>>>                 "extra": {
>>>>                       /* entry-specific stuff here */
>>>>                 }
>>>>             },
>>>>
>>>> ?
>>>>
>>>> And how bad would the code look like for this?
>>> You mean like add "extra" field to the payload, right?
>>> Yes, it does look better.
>> Not exactly. I mean no "payload" keyword in the output, just
>> the "extra" one for those with extra data (pipe-data, IPC).
> 
> Ok, will fix.
> 
> So, are you okay with names being tossed around if using json?

What names? The "extra" one is OK, but the "payload" looks like
excessive thing, if it's possible to get rid of one in the output
_easily_ (i.e. -- w/o ugly hacks in the crit code) then I'd prefer
not seeing it.

Thanks,
Pavel



More information about the CRIU mailing list