[CRIU] Criu mod to restore files to state when checkpoint taken ...

[Tycho Andersen]

On Fri, Jan 02, 2015 at 01:22:15PM -0500, Christopher Covington wrote:
> Hi Pavel,
> 
> On 12/31/2014 08:50 AM, Pavel Emelyanov wrote:
> > On 12/31/2014 03:53 PM, "Mark O'Neill" wrote:
> 
> >> 3. The required kernel functions (described on Criu website) must be
> >> added as modules (-=m) and not hardwired into kernel (=y) in Linux
> >> config file.
> > 
> > This is strange. What problems have you seen with all-in kernel?
> 
> At least for me, commit 2b5d06817f1bb2b28eec50b6705b1584435e580b introduced
> the following, which is actually spurious:
> 
> (00.098217) Error (util.c:576): exited, status=1
> (00.164971) Error (util.c:576): exited, status=1
> (00.216945) Error (util.c:576): exited, status=1
> (00.296716) Error (util.c:576): exited, status=1
> (00.368518) Error (util.c:576): exited, status=1
> 
> I originally proposed [1] a somewhat complex change of probing
> /proc/config.gz, but I think a quick and actually more general (as it doesn't
> require /proc/config.gz which is itself a configuration option) fix is to pass
> an fd to /dev/null into the cr_system() call.

Yes, the /dev/null trick seems a little nicer. Let me know if you want
me to send a patch; I haven't had much time for criu recently, but I'm
happy to fix the mess I created :)

Tycho

> 1. http://lists.openvz.org/pipermail/criu/2014-December/018352.html
> 
> Chris
> 
> -- 
> Qualcomm Innovation Center, Inc.
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project