[CRIU] CRIU unable to see external mounts while restore

[Pavel Emelyanov]

On 02/19/2015 11:36 AM, beproject criu wrote:
> I used criu 1.4. I have attached dump.log with the mail.

Oh, thank you very much :) We have a BUG in dumping code and you helped
us to spot one.

The dump had to fail in the first place. You have several mountpoints with
unspoorted filesystems, it's e.g. /system, /cache and /cache. What's in there?
If you update the sources to recent state these FSs will be in logs. If you
want to stick with 1.4, then just show the contents of /proc/self/mountinfo
from inside the container you dump.

The patch below fixes the dump so that it detects those mountpoints and aborts.
Let's find out what these mount points are and think how can we support their C/R.

diff --git a/mount.c b/mount.c
index 8d5ba8a..11651e4 100644
--- a/mount.c
+++ b/mount.c
@@ -2334,6 +2334,8 @@ int collect_mnt_namespaces(bool for_dump)
 		goto err;
 
 	if (for_dump && need_to_validate) {
+		ret = -1;
+
 		if (collect_shared(mntinfo))
 			goto err;
 		if (validate_mounts(mntinfo, true))


> The log file is huge it has lot of messages with tags [ vijay ] and [nyc] please ignore them,they are just
> for understanding the flow of criu.

Thanks,
Pavel