[CRIU] [PATCH 0/9] creds: Implement support of per-threds credentials

Andrew Vagin avagin at virtuozzo.com
Tue Dec 22 06:52:06 PST 2015


On Thu, Dec 17, 2015 at 12:14:08PM +0300, Cyrill Gorcunov wrote:
> Currently we can dump tasks which have same credentials over
> the all process tree. This makes us unable to dump for example
> Openswan. Lets make creds being per-thread as they should be
> from the very beginning but wasn't in sake of simplicily.
> 
> Guys, give it a look please, once time permit. I tested the
> series over real container with openswan running inside but
> not that intensively.
> 
> Comments are highly appreciated.
> 
> Cyrill Gorcunov (9):
>   x86: syscalls -- Wire in sys_setgroups
>   ppc64: syscalls -- Wire in sys_setgroups
>   arm: syscalls -- Wire in sys_setgroups
>   xmalloc: Add xmemdup helper
>   creds: protobuf -- Move @creds_entry into @thread_core_entry
>   creds: Allocate CredsEntry for every thread in core_entry_alloc
>   creds: Move proc_status_creds::cap_X at the end of structure
>   creds: restore -- Implement per-thread restore of credentials
>   creds: restore -- Implement per-thread dump of credentials
> 
>  arch/arm/syscall.def             |   1 +
>  arch/ppc64/syscall-ppc64.def     |   1 +
>  arch/x86/syscalls/syscall_32.tbl |   1 +
>  arch/x86/syscalls/syscall_64.tbl |   1 +
>  cr-dump.c                        |  41 +++---
>  cr-restore.c                     | 297 ++++++++++++++++++++++++---------------
>  include/parasite.h               |  58 ++++----
>  include/proc_parse.h             |  17 ++-
>  include/restorer.h               |  29 +++-
>  include/xmalloc.h                |   8 ++
>  parasite-syscall.c               |  79 +++++++----
>  pie/parasite.c                   |  71 +++++-----
>  pie/restorer.c                   |  33 +++--
>  proc_parse.c                     |  50 ++++++-
>  protobuf/core.proto              |   2 +
>  pstree.c                         |  31 +++-
>  ptrace.c                         |   2 +-
>  17 files changed, 456 insertions(+), 266 deletions(-)


How do you test this code? Could you add a test in zdtm?
> 
> -- 
> 2.5.0
> 


More information about the CRIU mailing list