[CRIU] [PATCH CRIU] cpt/rst: access and modification time of ghost files

Cyrill Gorcunov gorcunov at gmail.com
Tue Dec 22 01:11:41 PST 2015


On Tue, Dec 22, 2015 at 11:54:16AM +0300, Pavel Tikhomirov wrote:
> Modification time changes after cpt/rst file_attr test in VZ7CT:
> CT-102 criu# cat test/zdtm/live/static/file_attr.out
> 15:05:05.315:   146: FAIL: file_attr.c:101: modification time has
> changed (errno = 11 (Resource temporarily unavailable))
> 
> https://jira.sw.ru/browse/PSBM-41401
> Signed-off-by: Pavel Tikhomirov <ptikhomirov at virtuozzo.com>
> --- a/protobuf/ghost-file.proto
> +++ b/protobuf/ghost-file.proto
> @@ -8,4 +8,8 @@ message ghost_file_entry {
>  	optional uint32		dev		= 4 [(criu).dev = true];
>  	optional uint64		ino		= 5;
>  	optional uint32		rdev		= 6 [(criu).dev = true, (criu).odev = true];
> +	optional uint64		atim_sec	= 7;
> +	optional uint64		atim_usec	= 8;
> +	optional uint64		mtim_sec	= 9;
> +	optional uint64		mtim_usec	= 10;
>  }

Why not rather define timeval record, instead of all expanded?

message timeval {
	uint64 	sec = 0;
	...
}

message ghost_file_entry {
 ...
 optional timeval atime;
 optional timeval mtime;
}


More information about the CRIU mailing list