[CRIU] [PATCH] mnt: disable the use of pivot_root in case of ramdisk

Andrew Vagin avagin at odin.com
Mon Dec 21 23:43:22 PST 2015


On Thu, Dec 17, 2015 at 04:20:51PM +0300, Andrew Vagin wrote:
> On Sat, Oct 31, 2015 at 11:51:27PM +0100, ismael wrote:
> > --- a/mount.c
> > +++ b/mount.c
> > @@ -2246,6 +2246,25 @@ static int cr_pivot_root(char *root)
> >  		}
> >  	}
> >  
> > +	if (opts.ramdisk) {
> 
> cr_pivot_root() is called twice:
> 
> 1. to switch root of the root mount namespace
> 
> 2. to switch root of a sub-mount namespace
> 
> This code should be executed only for the first case. And pivot_root
> should be used to restore sub-namespaces, because it allow to clean up
> of extra mounts.
>

Hi Ismael,

Are you going to fix this? If you don't have time now, I can help.

Thanks,
Andrew.


More information about the CRIU mailing list