[CRIU] [PATCH 8/9] creds: restore -- Implement per-thread restore of credentials

[Cyrill Gorcunov]

On Thu, Dec 17, 2015 at 09:07:59AM -0700, Tycho Andersen wrote:
> > 
> > Currently we have one image per task, so we open it this way, because
> > there can't be creds per thread images. Or oyu mean something else?
> 
> I was thinking of the case where a task has N threads, this means that
> if you dump this task with old criu and restore it with a criu with
> this patchset, it'll open the creds image for that task N times.

It won't, as far as I understand. The threads are created inside
restorer actually (we even have clone() call written in pure assembly :)
in turn when saving threads only creds for group leader is saved
in image and on restore we read it once as well.

> I don't think it's such a big deal though, so let's forget about it.
> 
> > > On a similar note, the linked list with mem_pos_next seemed a little
> > > weird, but I don't have a better suggestion :(
> > 
> > I would love to make it less weird either :)
> 
> Yeah. Unfortunately I think this might be the least weird it can be
> :)