[CRIU] [PATCH 2/4] test: setuid in seccomp_filter test to have it fail

Tycho Andersen tycho.andersen at canonical.com
Wed Dec 16 08:15:08 PST 2015


Signed-off-by: Tycho Andersen <tycho.andersen at canonical.com>
---
 test/zdtm/live/static/seccomp_filter.c | 11 +----------
 1 file changed, 1 insertion(+), 10 deletions(-)

diff --git a/test/zdtm/live/static/seccomp_filter.c b/test/zdtm/live/static/seccomp_filter.c
index 700e4de..805ad69 100644
--- a/test/zdtm/live/static/seccomp_filter.c
+++ b/test/zdtm/live/static/seccomp_filter.c
@@ -100,16 +100,7 @@ int main(int argc, char ** argv)
 		if (filter_syscall(__NR_getpid) < 0)
 			_exit(1);
 
-		/* FIXME: seccomp requires a task to be root in its user ns in
-		 * order to install filters for security reasons, so that
-		 * unprivileged parents cannot take over privileged childen.
-		 * However, we restore euids before we restore seccomp filters,
-		 * so if someone does a setuid(1000) here, the restore will
-		 * fail. We need to reorder some things so that the other creds
-		 * restore takes place after seccomp state is set; except that
-		 * the tasks need to be ptraced so the seccomp filters
-		 * potentially don't kill the task for calling setuid().
-		 */
+		setuid(1000);
 
 		zdtm_seccomp = 1;
 		test_msg("SECCOMP_MODE_FILTER is enabled\n");
-- 
2.5.0



More information about the CRIU mailing list