[CRIU] [Process Migration using Sockets v4 - Patch 1/3]

[Rodrigo Bruno]

Hi,

On Tue, 15 Dec 2015 13:56:02 +0300
Pavel Emelyanov <xemul at parallels.com> wrote:

> On 12/12/2015 01:18 AM, Rodrigo Bruno wrote:
> > Hi, 
> > 
> > I think I fixed all the comments you added in the last version of the patch.
> > 
> > It took me a little longer to send the new version because a I found a bug when
> > a subprocess that was snapshoted by a predump no longer exists when the dump takes
> > place. I was not considering that situation (but now it is perfectly okey).
> > 
> > I also took some time to use the checkpatch.pl from linux. I fixed all the code.
> > 
> > Here is the first part of the patch:
> 
> OK, great :) I think this version is ready for merging. To do that I need
> from you a patch commit message -- a good description of what's going on,
> protocol details, all that you wrote before, but what was left in previous
> e-mails. Please, send me one as a plain text, I'll paste it in the patch
> before committing.
> 
> The need for patch commit message also exists for patch #2, so please do
> it as well.

Great, I will do it for both patch 1 and 2.

> 
> Meanwhile I'll split the patch #1 and commit some pieces that make sense
> as themselves (next time, please, do it yourself in advance).

Sorry for the trouble...

> 
> As far as patch #3 is concerned -- such small test for such a huge change
> is too little :( Please, look at test/zdtm.py launcher, there's an ability
> run tests using page-server, change this launcher so that there appears a
> mode to dump via page cache and proxy.

Oh, okey, I will look into it.

> 
> -- Pavel

-- 
Rodrigo Bruno <rbruno at gsd.inesc-id.pt>