[CRIU] [PATCH] sysctl: really skip missing entries in __nonuserns_sysctl_op()

Ruslan Kuprieiev kupruser at gmail.com
Mon Dec 7 06:58:55 PST 2015


I agree, will fix it to make coding style Errors fatal and Warnings 
non-fatal.

Thank you for your feedback!

On 12/07/2015 02:19 PM, Andrey Ryabinin wrote:
> On 12/07/2015 03:15 PM, Ruslan Kuprieiev wrote:
>> Looks like problems with DOS endlines and missing mailing list are solved.
>> Yet checkpatch complains about line over 80 chars. Considering that code
>> style check is not fatal for tests and more like a recommendation, I think
>> we could leave it as is, as sometimes warnings are useful too and we could
>> signalize about them in such non-fatal way.
>>
> Perhaps Malipat should distinguish checkpatch WARNINGs and ERRORs.
> WARNINGS sometimes acceptable, while all ERRORs should be fixed.
>
>
>> On 12/07/2015 02:02 PM, Malipat wrote:
>>> Patch doesn't respect coding style.
>>> Patch applies successfully.
>>> Patch builds successfully.
>>> Patch passes tests successfully.
>>>
>>> SUCCESS
>>> _______________________________________
>>> CRIU Malipat(MAiling LIst PAtch Tester).
>>>
>>>
>>> _______________________________________________
>>> CRIU mailing list
>>> CRIU at openvz.org
>>> https://lists.openvz.org/mailman/listinfo/criu



More information about the CRIU mailing list