[CRIU] [PATCH] sysctl: really skip missing entries in __nonuserns_sysctl_op()

[Ruslan Kuprieiev]

I've fixed those bugs and rescheduled your patch.
New report should be sent to you and crml soon.
Could you please tell me if it comes or not(like in 10-20 minutes or so),
was check successful or not and whether or not it came with proper
In-Reply-To(report should be seen as a reply message to your original email
with patch).

Sorry for inconvenience.

Thanks,
Ruslan

On 12/07/2015 01:10 PM, Ruslan Kuprieiev wrote:
> Hi Andrey,
>
> You are right, there is definitely a bug on malipat side.
> And it seems like it's responses don't get to mailing list,
> but instead reach sender directly, which is a bit odd.
>
> Thanks for your feedback.
>
> On 12/07/2015 12:59 PM, Andrey Ryabinin wrote:
>> On 12/07/2015 01:38 PM, Malipat wrote:
>>> Patch doesn't respect coding style.
>> It seems that these 'DOS line endings' is a problem on Malipat side:
>>
>> $ cat checkpatch.log
>> ERROR: DOS line endings
>> #83: FILE: sysctl.c:365:
>> +^I^I^Iif (errno == ENOENT && (req->flags & CTL_FLAGS_OPTIONAL)) {^M$
>>
>> WARNING: line over 80 characters
>> #83: FILE: sysctl.c:365:
>> +                       if (errno == ENOENT && (req->flags & 
>> CTL_FLAGS_OPTIONAL)) {
>>
>> ERROR: DOS line endings
>> #84: FILE: sysctl.c:366:
>> +^I^I^I^Ireq++;^M$
>>
>> ERROR: DOS line endings
>> #86: FILE: sysctl.c:368:
>> +^I^I^I}^M$
>>
>> total: 3 errors, 1 warnings, 11 lines checked
>>
>> malipat.patch has style problems, please review.
>>
>> NOTE: If any of the errors are false positives, please report
>>        them to the maintainer, see CHECKPATCH in MAINTAINERS.
>>
>>
>>
>>
>> $ ./checkpatch.pl 
>> 0001-sysctl-really-skip-missing-entries-in-__nonuserns_sy.patch
>> WARNING: line over 80 characters
>> #27: FILE: sysctl.c:365:
>> +                       if (errno == ENOENT && (req->flags & 
>> CTL_FLAGS_OPTIONAL)) {
>>
>> total: 0 errors, 1 warnings, 11 lines checked
>>
>> 0001-sysctl-really-skip-missing-entries-in-__nonuserns_sy.patch has 
>> style problems, please review.
>>
>> NOTE: If any of the errors are false positives, please report
>>        them to the maintainer, see CHECKPATCH in MAINTAINERS
>>
>> _______________________________________________
>> CRIU mailing list
>> CRIU at openvz.org
>> https://lists.openvz.org/mailman/listinfo/criu
>