[CRIU] [PATCH] sysctl: really skip missing entries in __nonuserns_sysctl_op()
Andrey Ryabinin
aryabinin at virtuozzo.com
Mon Dec 7 02:59:25 PST 2015
On 12/07/2015 01:38 PM, Malipat wrote:
> Patch doesn't respect coding style.
It seems that these 'DOS line endings' is a problem on Malipat side:
$ cat checkpatch.log
ERROR: DOS line endings
#83: FILE: sysctl.c:365:
+^I^I^Iif (errno == ENOENT && (req->flags & CTL_FLAGS_OPTIONAL)) {^M$
WARNING: line over 80 characters
#83: FILE: sysctl.c:365:
+ if (errno == ENOENT && (req->flags & CTL_FLAGS_OPTIONAL)) {
ERROR: DOS line endings
#84: FILE: sysctl.c:366:
+^I^I^I^Ireq++;^M$
ERROR: DOS line endings
#86: FILE: sysctl.c:368:
+^I^I^I}^M$
total: 3 errors, 1 warnings, 11 lines checked
malipat.patch has style problems, please review.
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
$ ./checkpatch.pl 0001-sysctl-really-skip-missing-entries-in-__nonuserns_sy.patch
WARNING: line over 80 characters
#27: FILE: sysctl.c:365:
+ if (errno == ENOENT && (req->flags & CTL_FLAGS_OPTIONAL)) {
total: 0 errors, 1 warnings, 11 lines checked
0001-sysctl-really-skip-missing-entries-in-__nonuserns_sy.patch has style problems, please review.
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS
More information about the CRIU
mailing list