[CRIU] [PATCH] Skip restoring the cgroup root directories when using full mode

[Hui Kang]

On Tue, Aug 25, 2015 at 11:38 PM, Andrew Vagin <avagin at gmail.com> wrote:
> On Tue, Aug 25, 2015 at 06:42:38PM +0300, Andrew Vagin wrote:
>> On Tue, Aug 25, 2015 at 06:26:08PM +0300, Andrew Vagin wrote:
>> > I think the idea of restoring the root directories is wrong if you don't
>> > dump all processes on the host... It isn't actually about this patch,
>> > it's abount the manage-cgroups "full" mode.
>>
>> Hi Hui,
>>
>> Can we skip the root directories? We can think that if we meet a root
>> directory, this meens that a process doesn't use this controller?
>
> I was too tired yesterday. Today I found that suggested you to do, what
> you already do. Sorry for that and pls ignore my previous comments in
> this thread.

Hi, Andrew,
Thanks for the update. Actually I re-submitted the patch (should add
v2) as in this thread. Besides cpuset, I found that the root directory
of memory can not be written by criu either. Could you look at this?
Pavel proposed some bug that could be proposed by this patch. But,
somehow I can not produce the situation he described.

http://lists.openvz.org/pipermail/criu/2015-August/021759.html

- Hui


>
>>
>> Hui and Cirill, what do you think about this idea?
>>
>> >
>> > On Wed, Aug 12, 2015 at 07:36:22PM +0000, Hui Kang wrote:
>> > > Signed-off-by: Hui Kang <hkang.sunysb at gmail.com>
>> > > ---
>> > >  cgroup.c | 4 ++++
>> > >  1 file changed, 4 insertions(+)
>> > >
>> > > diff --git a/cgroup.c b/cgroup.c
>> > > index a4e0146..51348ca 100644
>> > > --- a/cgroup.c
>> > > +++ b/cgroup.c
>> > > @@ -992,6 +992,10 @@ static int prepare_cgroup_dir_properties(char *path, int off, CgroupDirEntry **e
>> > >           CgroupDirEntry *e = ents[i];
>> > >           size_t off2 = off;
>> > >
>> > > +         if (strcmp(e->dir_name, "") ==0)  {
>> > > +                 continue;
>> > > +         }
>> > > +
>> > >           off2 += sprintf(path + off, "/%s", e->dir_name);
>> > >           if (e->n_properties > 0) {
>> > >                   for (j = 0; j < e->n_properties; ++j) {
>> > > --
>> > > 1.9.1
>> > >
>> > > _______________________________________________
>> > > CRIU mailing list
>> > > CRIU at openvz.org
>> > > https://lists.openvz.org/mailman/listinfo/criu
>> > _______________________________________________
>> > CRIU mailing list
>> > CRIU at openvz.org
>> > https://lists.openvz.org/mailman/listinfo/criu
>> _______________________________________________
>> CRIU mailing list
>> CRIU at openvz.org
>> https://lists.openvz.org/mailman/listinfo/criu