[CRIU] [PATCH] Skip restoring the cgroup root directories when using full mode

Hui Kang hkang.sunysb at gmail.com
Tue Aug 25 08:33:10 PDT 2015


On Tue, Aug 25, 2015 at 11:26 AM, Andrew Vagin <avagin at gmail.com> wrote:
> I think the idea of restoring the root directories is wrong if you don't
> dump all processes on the host... It isn't actually about this patch,
> it's abount the manage-cgroups "full" mode.

Agreed. So the patch actually should avoid restoring the root
directory if manage-group is set to full. What do you think?

- Hui

>
> On Wed, Aug 12, 2015 at 07:36:22PM +0000, Hui Kang wrote:
>> Signed-off-by: Hui Kang <hkang.sunysb at gmail.com>
>> ---
>>  cgroup.c | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/cgroup.c b/cgroup.c
>> index a4e0146..51348ca 100644
>> --- a/cgroup.c
>> +++ b/cgroup.c
>> @@ -992,6 +992,10 @@ static int prepare_cgroup_dir_properties(char *path, int off, CgroupDirEntry **e
>>               CgroupDirEntry *e = ents[i];
>>               size_t off2 = off;
>>
>> +             if (strcmp(e->dir_name, "") ==0)  {
>> +                     continue;
>> +             }
>> +
>>               off2 += sprintf(path + off, "/%s", e->dir_name);
>>               if (e->n_properties > 0) {
>>                       for (j = 0; j < e->n_properties; ++j) {
>> --
>> 1.9.1
>>
>> _______________________________________________
>> CRIU mailing list
>> CRIU at openvz.org
>> https://lists.openvz.org/mailman/listinfo/criu


More information about the CRIU mailing list