[CRIU] [PATCH 2/6] crit: add --format hex option

Christopher Covington cov at codeaurora.org
Tue Aug 11 12:26:18 PDT 2015


On 08/11/2015 01:57 PM, Ruslan Kuprieiev wrote:
> Hi Christopher
> 
> I don't think this is that much necessary, but I thought it was the
> less ugly way at that time. If I recall correctly, one of the main factors
> was that protobuf compiler can't place compiled files other that where
> the original *.proto file is situated, and I was not happy about that way
> of system pollution.
> 
> I would highly appreciate if you could fix it in a nice way.

While debugging, I notice the variables that control verbosity, E and Q,
aren't set properly when protobuf/Makefile is called. They could be exported
in Makefile after Makefile.inc is included, demonstrated below (my first try
at supporting `git am --scissors`), but perhaps there's a nicer way?

Thanks,
Christopher Covington

-- >8 --

diff --git a/Makefile b/Makefile
index 7f5c890..06c68c0 100644
--- a/Makefile
+++ b/Makefile
@@ -177,6 +177,8 @@ include Makefile.config
 include scripts/Makefile.version
 include scripts/Makefile.rules

+export E Q
+
 .SUFFIXES:

 #

-- 
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project


More information about the CRIU mailing list