[CRIU] [PATCH 3/3] proc-parse: Drop deleted postfix from the mountpoint root

[Saied Kazemi]

A couple of points:

1. This patch fixes the restore failure that Mark reported with a simple
/sbin/init workload.  I haven't taken a deeper look to see what this patch
can break.

2. Regarding fixing the issue in libcontainer, as far as I understand, the
problem actually happens at checkpoint time when the pathname is
erroneously recorded as /null//deleted in mountpoint-11.img.  As Andrew
mentioned, this happens because /sbin/init deletes /dev/null and recreates
it.

--Saied


On Tue, Aug 11, 2015 at 7:44 AM, Cyrill Gorcunov <gorcunov at gmail.com> wrote:

> On Tue, Aug 11, 2015 at 11:37:59AM +0300, Andrew Vagin wrote:
> > On Mon, Aug 10, 2015 at 11:34:27AM +0300, Cyrill Gorcunov wrote:
> > > This address only a part of a problem with deleted mountpoint,
> > > so rather a fast fix to not block development, but warning
> > > issued to nag us to not forget resolve it before the release.
> >
> > The result will be incorrect. Do we really want it? This issue can be
> > easy fixed in libcontainer which can mount /dev/null from a host file
> > system.
>
> As I said it fixes a part of a problem and issues a warning.
> If docker can handle this without a patch, then sure, no need
> for it. But as far as I understand Saied said it helps him.
>
> (sorry for delay in response, drowned in mails)
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openvz.org/pipermail/criu/attachments/20150811/c528d9bd/attachment.html>