[CRIU] [PATCH] Enable manage cgroup modes in criu service

[Pavel Emelyanov]

On 08/06/2015 01:38 PM, Ruslan Kuprieiev wrote:
> 
> 
> On 08/06/2015 01:09 PM, Pavel Emelyanov wrote:
>> On 08/06/2015 12:48 PM, Ruslan Kuprieiev wrote:
>>> Hi,
>>>
>>> Patch looks good to me.
>> OK, I'll put this tag on :)
>>
>>> But I've also noticed
>>> that we provide no way for a libcriu and rpc users
>>> to get those CG_MODE_* constants other than
>>> by looking directly into criu sources, which isn't
>>> nice. What do you guys think?
>> Definitely worth pulling them out into lib/criu.h.
> 
> And how about rpc? 

The same, the field is declared as int, so just include
the lib/cru.h and use constants from there.

> Looks like we would need to
> add enum there and parse it separately, which will
> lead to creating an additional enum in libcriu, as
> we would not able to just copy CG_MODE_* to libcriu
> header and use it there, because libcriu depends on rpc
> in a first place.
> .
>