[CRIU] [PATCH 0/2] crit core-dump feature, v2

[Ruslan Kuprieiev]

On 30.04.15 21:01, Pavel Emelyanov wrote:
> On 04/30/2015 08:47 PM, Christopher Covington wrote:
>> On 04/30/2015 02:47 AM, Pavel Emelyanov wrote:
>>> OK, this seems to be working already. However, there's one concern
>>> that we have to sort out -- it's whether or not to keep this converter
>>> in criu sources or outside. The thing is that criu itself has nothing
>>> to do with core files and debugging, it just happened that the amount
>>> of data it generates is sufficient for core. The same thing is about
>>> the p.haul -- it's tied with criu heavily, but still sits in a separate
>>> repository.
>>>
>>> Thoughts?
>> What are the practical disadvantages to inclusion? Are you worried that the
>> git repository might be very slightly larger? That sometimes when looking at
>> `git log -p` one might come across code unrelated to the problem at hand?
> No, it's vice-versa :) If we keep core-dump outside this would help us
> keep the pycriu API solid and compatible between versions. If we merge
> core-dump in, then chances to change pycriu significantly (and fixing
> the core-dump respectively) increase.

What do you mean by keeping pycriu api solid and compatible?
Pycriu was intended to be a collection of criu-related tools that one
could easily use in his python app. Making core-dump functionality
available in pycriu makes perfect sense.
Decode\encode functionality from pycriu.images isn't affected by
this patch set. In fact, this patchset brings functions to read criu
images more deeply and which could be utilized in future by
other crit features.

> -- Pavel