[CRIU] [PATCH 0/2] crit core-dump feature, v2

[Pavel Emelyanov]

On 04/30/2015 01:24 PM, Ruslan Kuprieiev wrote:
> 
> 
> On 30.04.15 13:12, Pavel Emelyanov wrote:
>> Keeping pycriu in criu is OK, it's just an python API for images reading. But
>> core-dumper can sit outside and use this API thus making sure that the API is
>> usable:)
>>
>> -- Pavel
> 
> Pycriu package is not only about converting images. It also has rpc module
> inside to give people easy access to criu rpc. core-dump belongs to
> pycriu.images package as it takes care of CRIU images. Later we could
> also add migration module i.e. pycriu.migrator. 

What's that?

> So people could use all
> of that things in their applications through the python interface by simply
> importing pycriu package that has everything they need in it.
> And our cmdline utils as p.haul, crit decode/encode, crit core-dump are
> just using pycriu module.
> 
> I really think that keeping core_dump _python_ module outside of pycriu
> or crit is very bad idea that will only make things complicated for 
> everyone.

I agree that it's always hard to indentify really independent pieces. And
as far as working with images is concerned, it looks natural to have a tool
that provides and API to manipulate images in a generic form (part of pycriu
does so) and to have the rest separate.

On the other hand, I had in mind an ability to produce some stats about
criu images and making it a part of crit itself. With the current discussion
it seems that stats generator worth separate sub-project :)

Need to think.

> I'm sure that users would rather like to have every pythonic criu-related
> feature inside one pycriu python package and core-dump inside crit,
> rather than having a zoo of lots of tools with different locations and 
> interfaces.

Welcome to the unix world ;)

-- Pavel