[CRIU] [PATCH 0/2] crit core-dump feature, v2

[Ruslan Kuprieiev]

On 30.04.15 11:21, Cyrill Gorcunov wrote:
> On Thu, Apr 30, 2015 at 11:07:32AM +0300, Ruslan Kuprieiev wrote:
>> I can't agree that we should move core-dump outside as it is a logical part
>> of CRiu Image Tool -- it
>> transforms CRIU images into another form of saving state - core dump.  I'm
>> also afraid that making
>> core-dump feature standalone will make it harder for users to get it. If it
>> will be a part of crit -- users
>> will get everything in one package. It is also quite handy to have all
>> criu-images-related stuff under one
>> command - crit.
>>
>> P.haul analogy doesn't work here, as p.haul is a completely separate project
>> with a complex logic inside
>> and can't be united with anything in the main criu repo. Core-dump, in it's
>> turn, is a far less complex
>> and is a part of CRIT, which we ship along with criu, so I see no reason why
>> we should keep core-dump
>> outside criu repo and outside CRIT.
> Dunno, Ruslan, the core-dump may be a part of criu (for example I'm still
> hoping to move our make engine into a separate project and use it as a
> git submodule), but simply living in a separate repo (still be on criu.org)
> with you as a project maintainer.
>
> The thing is that -- we can't live without crit (because as I said we
> rely on its "view" feature) but as to core-dump is not that obvious
> to me. So I leave it up to Pavel. Personally I can live with both
> in- and out- of repo choise, but prefer the last.

Well, but core-dump is a part of pycriu python module and splitting module
in parts doesn't seem very convenient... How about moving pycriu module
into separate project with its own repo? Pycriu module is used by crit 
through
a regular python interface "import pycriu", so it should be easy to separate
one from another... Pycriu module can also be extended to have some part
of p.haul logic to orginize migrating stuff. So if one wants to use cmdline
he could use "crit decode/encode", "crit core-dump" and "p.haul", but if one
wants to use pycriu in his own app -- "import pycriu.images",
"import pycriu.migrator" =).

Btw pycriu repo could be used as a git submodule.

What do you guys think about it?