[CRIU] [PATCH] arch/ppc64: Add PowerPC 64 LE support

Pavel Emelyanov xemul at parallels.com
Thu Apr 30 02:35:47 PDT 2015


>> Can we beautify this a little bit by doing the
>>
>> #define __export_restore_task __export_restreo_task_trampoline
>> #define __export_unmap __export_unmap_trampoline
>>
>> somewhere outside of the sigreturn_restore()?
> 
> I do agree.
> 
> What about letting the arch overwriting these symbols and in the case
> there is no arch specific symbol, falling back to the default ones.
> 
> I mean something like that :
> 
> arch/ppc64/include/asm/restore.h:
> #define arch_export_restore_task 	__export_restore_task_trampoline
> #define arch_export_unmap		__export_unmap_trampoline
> 
> cr-restore.c:
> #ifndef arch_export_restore_task
> #define arch_export_restore_task 	__export_restore_task
> #endif
> #ifndef arch_export_unmap
> #define arch_export_unmap		__export_unmap
> #endif

It would be even nicer, thanks :)

-- Pavel



More information about the CRIU mailing list