[CRIU] Sync TODO-s for mount.c work

Pavel Emelyanov xemul at parallels.com
Thu Apr 23 08:01:59 PDT 2015


On 04/23/2015 04:52 PM, Oleg Nesterov wrote:
> On 04/23, Pavel Emelyanov wrote:
>>
>> On 04/23/2015 02:17 PM, Oleg Nesterov wrote:
>>
>>> Now what? Obviously we can't just add
>>>
>>> 	if (is_not_external_mount(m))
>>> 		continue;
>>
>> Why not? The is_not_external_mount() is
>>
>> fsroot_mounted(m) || /* mount's root is visible from chroot */
> 
> Yes, perhaps this can work as a first approximation, but afaics this
> is not enough with MS_SLAVE...
> 
> Hmm. I can't check this because I can no longer compile criu after
> git pull,
> 
> 	make[1]: *** No rule to make target `include/asm-generic/page.h', needed by `arch/x86/crtools.o'.  Stop.
> 	make: *** [arch/x86/crtools.built-in.o] Error 2
> 
> Damn. I'll continue after I solve this problem...

Do "make clean" then make again. We have some issue with Makefiles
that renames/deletions are not tracked properly (Cyrill?).

-- Pavel



More information about the CRIU mailing list