[CRIU] [PATCH 2/2] Always re-build version.h

Cyrill Gorcunov gorcunov at gmail.com
Thu Apr 16 02:42:17 PDT 2015


On Thu, Apr 16, 2015 at 12:24:48PM +0300, Pavel Emelyanov wrote:
> On 04/15/2015 08:46 PM, Tycho Andersen wrote:
> > This might be a slightly controversial change since it always causes crtools.h
> > to be rebuilt, which may be annoying. However, right now version.h is only
> > generated on the initial git build and never again touched, which is also
> > incorrect.
> > 
> > We could potentially do something fancy by monitoring .git/HEAD for changes,
> > but since it may not always exist if building from a tarball, it is a little
> > sticky.
> > 
> > Signed-off-by: Tycho Andersen <tycho.andersen at canonical.com>
> 
> Well, "make" on freshly built tree re-build several files. This is indeed
> annoying. Is there anything better that can be done about it?
> 
> Cyrill?

I don't like this idea either, gimme sometime, maybe we invent something...


More information about the CRIU mailing list