[CRIU] [PATCH 2/2] Always re-build version.h

Tycho Andersen tycho.andersen at canonical.com
Wed Apr 15 10:46:39 PDT 2015


This might be a slightly controversial change since it always causes crtools.h
to be rebuilt, which may be annoying. However, right now version.h is only
generated on the initial git build and never again touched, which is also
incorrect.

We could potentially do something fancy by monitoring .git/HEAD for changes,
but since it may not always exist if building from a tarball, it is a little
sticky.

Signed-off-by: Tycho Andersen <tycho.andersen at canonical.com>
---
 scripts/Makefile.version | 1 +
 1 file changed, 1 insertion(+)

diff --git a/scripts/Makefile.version b/scripts/Makefile.version
index 53ee537..358eea4 100644
--- a/scripts/Makefile.version
+++ b/scripts/Makefile.version
@@ -6,6 +6,7 @@ ifeq ($(GITID),)
 	GITID := 0
 endif
 
+.PHONY: $(VERSION_HEADER)
 $(VERSION_HEADER): Makefile scripts/Makefile.version
 	$(E) "  GEN     " $@
 	$(Q) echo "/* Autogenerated, do not edit */"			 > $(VERSION_HEADER)
-- 
2.1.4



More information about the CRIU mailing list