[CRIU] [PATCH 0/5] revert 246367e4e483 "add walk_all flag to walk_namespaces"

[Tycho Andersen]

Hi Oleg,

On Tue, Apr 14, 2015 at 06:53:47PM +0200, Oleg Nesterov wrote:
> Hello.
> 
> Perhaps I am totally confused, this is quite possible. But it seems
> that we need at least to try to cleanup this code. Before we try to
> fix it. Lets start with  the "we need the criu's mi if auto" logic.
> 
> To me, this "walk_all" logic buys nothing and just complicates the code.
> Just look at this "ns->pid != getpid() || !(root_ns_mask & CLONE_NEWNS)"
> check in collect_mntns(). It is horrible! At least it is certainly not
> easy to understand it.
> 
> Tycho, could you please review? I am _not_ sure I understood this code
> correctly. Help.

Yes, moving it out of walk_namespaces is fine with me (I only added it
there after review :). Anyway, I looked at this series and it looks
good, and it also c/rs my testcases correctly:

Tested-by: Tycho Andersen <tycho.andersen at canonical.com>

> Oleg.
>