[CRIU] [PATCH 0/1] do_new_mount() should clear all do_change_type() bits

Oleg Nesterov oleg at redhat.com
Mon Apr 13 10:48:11 PDT 2015


On 04/13, Oleg Nesterov wrote:
>
> So I hit the new problems with criu. I'll write another email,
> I beleive the recent --ext-mount-map auto were not 100% correct.

Yes, the more I read this code the more I think it is wrong. But sorry,
have no time to explain today. Will try tomorrow.

And yes, it seems that 2 simple fixes I sent makes sense in any case.
Even if we will (probably) need to change restore_shared_options() in
do_new_mount() later.

And cough... I can't resist ;) I understand that it is very easy to
blame the code which I do not understand even remotely, but imo
collect_mnt_namespaces() -> collect_mntns() paths ask for cleanups.


> But don't we need this change in any case? So far I do not know
> how to test it, but it seems that do_new_mount()->mount() will
> obviously fail if MS_SLAVE is set?
> 
> Please review, so far only compile tested.
> 
> Oleg.



More information about the CRIU mailing list