[CRIU] [PATCH] propogate the error if resolve_external_mounts() fails

Tycho Andersen tycho.andersen at canonical.com
Mon Apr 13 10:38:02 PDT 2015


On Mon, Apr 13, 2015 at 06:27:35PM +0200, Oleg Nesterov wrote:
> collect_mnt_namespaces() returns with ret=0 if resolve_external_mounts()
> fails.

Whoops, thanks:

Acked-by: Tycho Andersen <tycho.andersen at canonical.com>

> Signed-off-by: Oleg Nesterov <oleg at redhat.com>
> ---
>  mount.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/mount.c b/mount.c
> index 55d5f8b..f3ebd1d 100644
> --- a/mount.c
> +++ b/mount.c
> @@ -2671,7 +2671,8 @@ int collect_mnt_namespaces(bool for_dump)
>  	if (ret)
>  		goto err;
>  
> -	if (resolve_external_mounts(mntinfo))
> +	ret = resolve_external_mounts(mntinfo);
> +	if (ret)
>  		goto err;
>  
>  	if (arg.need_to_validate) {
> -- 
> 1.5.5.1
> 
> 


More information about the CRIU mailing list