[CRIU] [PATCH v2 5/5] introduce --enable-fs cli option

[Oleg Nesterov]

On 04/10, Pavel Emelyanov wrote:
>
> On 04/10/2015 03:40 PM, Oleg Nesterov wrote:
> >
> > What should we do if the user does
> >
> > 	$ criu dump --enable-fs all --enable-fs autofs
> >
> > ? Should "all" always win?
>
> Apparently yes :) It's a union. All UNION autofs == All

OK.

> > And another question... "restore" ignores this option. This is fine,
> > but perhaps a warning makes sense. Unfortunately main()->getopt_long()
> > logic doesn't allow to do this simply. Perhaps we should change main()
> > to require the command in argv[1] ?
>
> At the end of option parsing you can check that we doing restore
> and warn if the fsauto_names is no NULL.

Sure. Just this looks unnecessarily complicated. It would be much better
If we could nack this (and other dump-only options) at the start.

We do not really want to export fsauto_names. And "bool has_enable_fs"
in main() doesn't look nice too. IMO it would be much better to change
criu to parse the options depending on command == argv[1], like git
does. OK, this is off-topic right now.

Oleg.