[CRIU] [PATCH] x86: syscalls -- Rework building procedure

Pavel Emelyanov xemul at parallels.com
Fri Apr 10 03:39:31 PDT 2015


On 04/09/2015 11:45 AM, Cyrill Gorcunov wrote:
>  - Get rid of shell script, we can do everything via make itself in parallel mode

What's the benefit of in-Make code vs shell script?

>  - Collect syscall related data into syscalls subdirectory (we gonna implement
>    32 bit mode soon)

What else is going to be in this directory?

>  - We can't drop off __NR_ constants because we're using them in parasite code
>    (when we inject dumper and for "criu exec" mode)

OK


> -$(obj)/$(SYS-EXEC-TBL): $(obj)/$(SYS-GEN) $(obj)/$(SYS-DEF)
> +	$(Q) echo "/* Autogenerated, don't edit */"										>  $@
> +	$(Q) echo "#ifndef __ASM_CR_SYSCALL_CODES_H__"										>> $@
> +	$(Q) echo "#define __ASM_CR_SYSCALL_CODES_H__"										>> $@
> +	$(Q) cat $< | egrep -v '^#' | sed -e 's/\t\{1,\}/|/g' | awk -F '|' '{print "#define " $$1 " " $$2 }'			>> $@
> +	$(Q) echo "#endif /* __ASM_CR_SYSCALL_CODES_H__ */"									>> $@

Can we fix these long lines? They don't fit even in my wide screen ;)

-- Pavel


More information about the CRIU mailing list