[CRIU] [RFC PATCH 0/5] introduce --enable-fs cli option

Oleg Nesterov oleg at redhat.com
Thu Apr 9 10:46:11 PDT 2015


Hello, and sorry for delay.

Almost the same as V1, just some cosmetics changes. Seems to work.

I decided to keep mnt_entry->fsname and avoid the "clever" games with
dump/resore auto fsnames once. Because:

	1. I am lazy and you seem to agree with ->fsname ;)

	2. Your protobuf/mnt.proto is stupid (wrong afaics) and this
	   means that I need to write more changes...

	   Why do we expose "enum fstype" to protobufs at all? Please
	   note that typeof(mnt_entry->fstype) is uint32, not "fstype".

Pavel, I didn't convert fstypes[] into the list as you suggested. Can
I do this in a separate patch? Because personally I think this makes
no sense and this (trivial) code will look worse, so we can discuss
this simple change separately, including the cosmetic issues like the
necessary ctor for non-auto entries.

TODO: resolve_source() && FSTYPE__AUTO. I'll resend my hack later, if/
when you accept this series. This needs another (more) discussion too.

Plus support this option (and skip-mnt) in RPC, but this looks simple.

Oleg.



More information about the CRIU mailing list