[CRIU] automatic detection of external bind mounts

[Pavel Emelyanov]

On 04/09/2015 05:51 PM, Tycho Andersen wrote:
> Hi Pavel,
> 
> On Thu, Apr 09, 2015 at 01:14:12PM +0300, Pavel Emelyanov wrote:
>> On 04/08/2015 02:37 AM, Tycho Andersen wrote:
>>> Hi all,
>>>
>>> This series is (I think) an implementation of what we've discussed r.e.
>>> automatically detecting external bind {private|shared|slave} mounts. Thoughts
>>> are welcome.
>>
>> Can you also help me to update the test/mounts/ext/ directory
>> respectively? :)
> 
> Yes, definitely.

Thanks!

>> Right now there's only one test for plugin-based 
>> external mount c/r, I will resurrect my --ext-mount-map test and
>> put it there this week. If you could add the test for auto detection
>> and shared/slave external, that would be awesome!
> 
> I tried initially to write a test for this patchset (you can see a draft at
> [1]), but I couldn't get it working successfully. After I pivot_root in the
> test, criu fails to dump:
> 
> (00.002741) Error (files-reg.c:821): Unable to look up the 19 mount
> (00.002755) Error (cr-dump.c:1616): Dump files (pid: 5912) failed with -1
> (00.002988) Error (cr-dump.c:1979): Dumping FAILED.
> 
> Mount id 19 is /dev in this case; so I suppose I have to re-create most of the
> fs inside the pivot_root in order to c/r? Is there an easier way to test this?

Well, I'm about to send the enlightened version of this test right now (while
resurrecting the option test, I found out, that I reworked the plugin test
itself that time).

The existing set of scripts does complex things, that are really hard to debug.

-- Pavel