[CRIU] [PATCH 2/2] introduce --skip-mnt cli option

[Pavel Emelyanov]

> @@ -1004,6 +1035,13 @@ struct mount_info *parse_mountinfo(pid_t pid, struct ns_id *nsid, bool for_dump)
>  			goto end;
>  		}
>  
> +		if (for_dump && should_skip_mount(new->mountpoint + 1)) {

Sorry for being tedious, but I've found two more ... semantic problems with this option.

The first is -- two or more mountpoints can have the same path in "mountpoint". E.g.
# mount -t tmpfs none /tmp
# mount -t ext4 none /tmp
and we have two mounts on /tmp. This patch will skip both.

The second is -- if we have child mounts, then dump will be aborted due to inability
to resolve parent for child mounts.

I'm not sure how expected these two things from the user perspective are. For the latter,
I think that skipping the whole subtree is expected. For the former -- I don't know.

Thoughts?

-- Pavel