[CRIU] [PATCH 2/9] opt: cpu-cap -- Introduce "none" and "cpuinfo" arguments

[Cyrill Gorcunov]

On Tue, Sep 30, 2014 at 02:02:50PM +0400, Pavel Emelyanov wrote:
> > -"     --cpu-cap CAP      require certain cpu capability. CAP: may be one of:\n"
> > -"                        'fpu','all'. To disable capability, prefix it with '^'.\n"
> > +"     --cpu-cap [CAP]    require certain cpu capability. CAP: may be one of:\n"
> > +"                        'cpuinfo','fpu','all','none'. To disable capability, prefix it with '^'.\n"
> 
> What's the point in none? Does it differ from "no option"?

The image may have cpuinfo dumped and it will refusre to restore if destination
node doesn't have all caps matched. For this sake if user still needs to proceed
he may pass "none" parameter and criu ignore any caps.

In next patches:

int cpu_validate_features(CpuinfoX86Entry *img_x86_entry)
+{
+	/*
+	 * A user knows what he is doing and disabled
+	 * capabilities check.
+	 */
+	if (opts.cpu_cap == CPU_CAP_NONE)
+		return 0;

> 
> I don't like the "cpuinfo" name. Maybe just "cpu" or at least "cpuid"?
> Can we make it somehow symmetrical to "fpu" one?

Sure, I'll rename to "cpu".