[CRIU] [PATCH 4/9] cpuinfo: x86 -- Rework cpuinfo features fetching

Pavel Emelyanov xemul at parallels.com
Tue Sep 30 03:05:05 PDT 2014


On 09/25/2014 05:03 PM, Cyrill Gorcunov wrote:
> Instead of parsing procfs lets use native cpuid(), it's a way faster.
> The dark side is that the kernel may disable some of features via
> bootline options even if they are present on hardware but for us
> it's fine -- we will be testing hardware cpu for features anyway.
> 
> The X86_FEATURE_ bits are gathered from two sources: linux kernel
> and cpu specifications.
> 
> Same time drop off cpu_set_feature() helper -- it's unneeded.
> 
> Signed-off-by: Cyrill Gorcunov <gorcunov at openvz.org>

Can we split this patch?
Suggestions to parts:

1. s/cpu_has/cpu_has_feature/
2. Add new bits into asm/cpu.h
3. Native cpuid calls code
4. The rest

?


More information about the CRIU mailing list