[CRIU] [PATCH 01/15] cpuinfo: x86 -- Add protobuf entry

Cyrill Gorcunov gorcunov at gmail.com
Wed Sep 24 07:05:09 PDT 2014


On Tue, Sep 23, 2014 at 10:02:20PM +0400, Pavel Emelyanov wrote:
 > --- /dev/null
> > +++ b/protobuf/cpuinfo.proto
> > @@ -0,0 +1,32 @@
> > +message cpuinfo_x86_entry {
> > +	enum vendor {
> > +		UNKNOWN		= 0;
> > +		INTEL		= 1;
> > +		AMD		= 2;
> > +	}
> > +
> > +	required vendor			vendor_id	= 1;
> > +	required uint32			cpu_family	= 2;
> > +	required uint32			model		= 3;
> > +	required string			model_name	= 4;
> > +
> > +	repeated uint32			features	= 5;
> > +
> > +	optional uint32			stepping	= 6;
> > +
> > +	optional uint32			physical_id	= 8;
> > +	optional uint32			siblings	= 9;
> > +	optional uint32			core_id		= 10;
> > +	optional uint32			cpu_cores	= 11;
> 
> Some of these fields are write-only. E.g. the physical_id one.

I'm reworking this series now, but these parameters are rather
for information only, we don't use it for restore but it might
be usefull in case if some problems get detected.

> 
> > +}
> > +
> > +message cpuinfo_entry {
> > +	required uint32			id		= 1;
> 
> What this ID stands for? It's also write-only.

Yeah, redundant, thanks!


More information about the CRIU mailing list