[CRIU] [PATCH] bdf: remove wrong optimization

Pavel Emelyanov xemul at parallels.com
Wed Sep 24 02:51:40 PDT 2014


On 09/24/2014 01:42 PM, Andrey Vagin wrote:
> This optimization skips all new read data.

How?

> Reported-by: Mr Jenkins
> Signed-off-by: Andrey Vagin <avagin at openvz.org>
> ---
>  bfd.c | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/bfd.c b/bfd.c
> index 1ced0b0..70c7028 100644
> --- a/bfd.c
> +++ b/bfd.c
> @@ -145,12 +145,6 @@ again:
>  	if (brefill(f))
>  		return BREADERR;
>  
> -	/*
> -	 * small optimization -- we've scanned b->bleft
> -	 * symols already, no need to re-scan them after
> -	 * the buffer refill.
> -	 */
> -	ss = b->bleft;
>  	refilled = true;
>  
>  	goto again;
> 



More information about the CRIU mailing list