[CRIU] [PATCH 3/3] lib: Use x[re|m]alloc, xstrdup helpers

Cyrill Gorcunov gorcunov at gmail.com
Tue Sep 23 11:05:21 PDT 2014


On Tue, Sep 23, 2014 at 09:48:01PM +0400, Pavel Emelyanov wrote:
> > 
> > We already use log helpers there
> > 
> > 	perror("Can't allocate memory for criu opts");
> > 	perror("Can't read response");
> > 	...
> 
> perror is not log helper. pr_perror is :)

Correct you are ;)

> 
> > but this is a good question. As far as I see pr_ helpers
> > remains unresolved indeed in library itself so it's up
> > to library user to provide print_on_level otherwise we
> > either
> > 
> >  1) link libcriu with our log engine
> 
> please, no

drop this one


More information about the CRIU mailing list