[CRIU] [PATCH] ptrace: flush breakpoints

[Pavel Emelyanov]

On 09/22/2014 01:59 PM, Andrew Vagin wrote:

>>> @@ -1599,6 +1599,18 @@ static int attach_to_tasks(bool root_seized, enum trace_flags *flag)
>>>  	return 0;
>>>  }
>>>  
>>> +static int clear_breakpoints()
>>> +{
>>> +	struct pstree_item *item;
>>> +	int ret = 0, i;
>>> +
>>> +	for_each_pstree_item(item)
>>> +		for (i = 0; i < item->nr_threads; i++)
>>> +			ret |= ptrace_flush_breakpoints(item->threads[i].real);
>>
>> Can we optimize this loop out on arches that don't support
>> breakpoints?
> 
> ARM and ARM64 have support of breakpoints. And lack of this optimization
> should motivate arm users to add suppport of breakpoints into CRIU;).
> 
> Seriously, I don't want to do this optimization to remove it in a
> future.

We won't remove it in a future. This will just lower the barrier for
new architectures -- they won't have to do breakpoints from the very
beginning. Please, add.

> Thanks,
> Andrew