[CRIU] [PATCH 0/5] cpuinfo: Rework cpuinfo dumping, make it optional

[Cyrill Gorcunov]

On Thu, Sep 18, 2014 at 08:10:09PM +0400, Pavel Emelyanov wrote:
> On 09/12/2014 02:15 PM, Cyrill Gorcunov wrote:
> > On Fri, Sep 12, 2014 at 02:04:45PM +0400, Pavel Emelyanov wrote:
> >> Can you sum up the API change you propose with this?
> >>
> > 
> > Currently (with this series applied)
> > ====================================
> > 
> >  - by default cpu caps are not dumped at all, one need to
> >    pass --cpu-cap all to force CRIU write cpu caps bits into
> >    the image
> 
> Why not just --cpu-cap, w/o any arguments?

Because "--cpu-cap fpu" is default mode already if we add --cpu-cap
as meaning of "--cpu-cap all" this would rather confuse people more,
no? That said it's not a problem to add it if you wish.

> 
> >  - on restore we test if image with cpuinfo is present on disk,
> >    and if so -- test that image is capable with runtime cpu
> 
> I like it. Can you do the following. Add two more actions -- dumpcpu
> and checkcpu (or smth like that to be consonant with the dump option).
> 
> And make sure this API is available via RPC and library.

Sure.