[CRIU] [PATCH] ptrace: Skip GETREGS on exits from syscalls when possible

Cyrill Gorcunov gorcunov at gmail.com
Tue Sep 16 01:24:06 PDT 2014


On Tue, Sep 16, 2014 at 12:27:07AM +0400, Pavel Emelyanov wrote:
> From: Pavel Emelyanov <xemul at parallels.com>
> 
> The PTRACE_SYSCALL traps task twice -- first on enter into
> and then on exit from syscall. If we trace a single task (and
> we do it on dump two times per task) we may skip half of all
> getregs calls -- on exit we don't need them.
> 
> Signed-off-by: Pavel Emelyanov <xemul at parallels.com>

Does it really saves us that much time so that we sacrifice logging?
Previously we always check that we're in good shape and log out
the syscall engine is about to yield. Thus I'm not sure if it
worth it (patch looks good though, I simply have a gut feeling
that one day we might hit some problem with it).


More information about the CRIU mailing list