[CRIU] [PATCH 2/2] zdtm/mountpoints: add "unknown" options to reproduce the previous bug

Ruslan Kuprieiev kupruser at gmail.com
Wed Sep 10 01:19:18 PDT 2014


Tested-by: Ruslan Kuprieiev <kupruser at gmail.com>

On 09.09.2014 23:17, Andrey Vagin wrote:
> tmpfs has the "size" option, which is not standard.
>
> Execute zdtm/live/static/mountpoints
> ./mountpoints --pidfile=mountpoints.pid --outfile=mountpoints.out
> Dump 2737
> WARNING: mountpoints returned 1 and left running for debug needs
> Test: zdtm/live/static/mountpoints, Result: FAIL
> ==================================== ERROR ====================================
> Test: zdtm/live/static/mountpoints, Namespace:
> Dump log   : /root/git/criu/test/dump/static/mountpoints/2737/1/dump.log
> --------------------------------- grep Error ---------------------------------
> (00.146444) Error (mount.c:399): Two shared mounts 50, 67 have different sets of children
> (00.146460) Error (mount.c:402): 67:./zdtm_mpts/dev/share-1 doesn't have a proper point for 54:./zdtm_mpts/dev/share-3/test.mnt.share
> (00.146820) Error (cr-dump.c:1921): Dumping FAILED.
> ------------------------------------- END -------------------------------------
> ================================= ERROR OVER =================================
>
> Signed-off-by: Andrey Vagin <avagin at openvz.org>
> ---
>   test/zdtm/live/static/mountpoints.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/test/zdtm/live/static/mountpoints.c b/test/zdtm/live/static/mountpoints.c
> index 4ce18d8..1e2c3c6 100644
> --- a/test/zdtm/live/static/mountpoints.c
> +++ b/test/zdtm/live/static/mountpoints.c
> @@ -225,7 +225,7 @@ done:
>   	}
>   
>   	mkdir(MPTS_ROOT"/dev/share-1/test.mnt.share", 0600);
> -	if (mount("none", MPTS_ROOT"/dev/share-1/test.mnt.share", "tmpfs", 0, "") < 0) {
> +	if (mount("none", MPTS_ROOT"/dev/share-1/test.mnt.share", "tmpfs", 0, "size=1G") < 0) {
>   		fail("Can't mount tmpfs");
>   		return 1;
>   	}



More information about the CRIU mailing list