[CRIU] [PATCH] restore: define root_as_sibling before using it

Pavel Emelyanov xemul at parallels.com
Tue Sep 9 10:53:22 PDT 2014


On 09/09/2014 09:51 PM, Tycho Andersen wrote:
> On Tue, Sep 09, 2014 at 09:47:12PM +0400, Pavel Emelyanov wrote:
>>
>>>> Can we just drop the && all together?
>>>
>>> IIRC the check for pdeath_sig was left not to restore every single
>>> process as criu's sibling. Smth wrong was with zdtm with it. Andrey
>>> should remember.
>>
>> I remembered. We run test in 3.11 which prohibits simultaneous
>> use of CLONE_PARENT and CLONE_NEWPID. But zdtm.sh may run all
>> tests in pid namespace to avoid PIDs clashing on restore. Thus
>> we only do CLONE_PARENT for non-pdeath_sig-ed tasks to make
>> this work at all.
> 
> I see. So the correct solution is just to leave the condition as-is,
> maybe with a comment explaining the 3.11 problem, so that we can
> remove it in future releases?

Yes, please :)

> Tycho
> 
>> Thanks,
>> Pavel
>>
>>
> 



More information about the CRIU mailing list