[CRIU] [PATCH 2/2] remap: add a dead pid /proc remap

[Tycho Andersen]

On Tue, Sep 09, 2014 at 04:16:52PM +0400, Pavel Emelyanov wrote:
> On 09/09/2014 02:26 PM, Andrew Vagin wrote:
> 
> >> @@ -1,4 +1,9 @@
> >> +enum remap_type {
> > Can we add a type for linked files? And I think its value should be 0.
> > 
> > 	LINKED			= 0;
> > 	PROCFS                  = 1;
> 
> With the separate patch only. And we should add 3 types, LINKED, GHOST and PROCFS.
> And the code restoring the ghost should look smth like
> 
> if (!remap->has_remap_type) {
> 	/* backward compatibility with images */
> 	if (remap->remap_id & REMAP_GHOST) {
> 		remap->remap_id &= ~REMAP_GHOST;
> 		remap->remap_type = GHOST;
> 	} else
> 		remap->remap_type = LINKED;
> }
> 
> switch (remap->remap_type) {
> 	case GHOST:
> 		/* restore ghost */
> 	case LINKED:
> 		/* restore linked */
> 	case PROCFS:
> 		/* restore procfs */
> }
> 
> And the dumping code should stop putting the REMAP_GHOST bit on
> the ID field :) But yet again -- with the separate patch on top.

Ok, this sounds good. I will resend the series.

Tycho

> Thanks,
> Pavel
> 
> > 
> >> +	PROCFS			= 0;
> >> +};
> >> +
> >>  message remap_file_path_entry {
> >>  	required uint32		orig_id		= 1;
> >>  	required uint32		remap_id	= 2;
> >> +	optional uint32		remap_type	= 3;
> >>  }
> >> -- 
> >> 1.9.1
> >>
> >> _______________________________________________
> >> CRIU mailing list
> >> CRIU at openvz.org
> >> https://lists.openvz.org/mailman/listinfo/criu
> > _______________________________________________
> > CRIU mailing list
> > CRIU at openvz.org
> > https://lists.openvz.org/mailman/listinfo/criu
> > .
> > 
>