[CRIU] zdtm test fail

[Ruslan Kuprieiev]

On 08.09.2014 13:46, Andrew Vagin wrote:
> On Mon, Sep 08, 2014 at 12:58:36PM +0300, Ruslan Kuprieiev wrote:
>> Well, with v1.3-rc2 "make test" doesn't fail.
>> Maybe someone who understands mountpoints is willing to take a look at it?
>> =)
> Could you find a commit, which is guilty of this?
>
> Tip: git bisect start origin/master v1.3-rc2

Thanks for a tip!

Bisecting: 0 revisions left to test after this (roughly 0 steps)
[8d446a7af4ef09e7ae7fca2c36594f7dd8622d77] mount: execute collect shared 
for all mounts

Also, error is a bit different:

cc -g -O2 -Wall -Werror -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=0 -iquote 
../../lib/arch/x86/include -I../../lib   mountpoints.c 
../../lib/libzdtmtst.a   -o mountpoints
./mountpoints --pidfile=mountpoints.pid --outfile=mountpoints.out
   PID TTY          TIME CMD
  4625 ?        00:00:00 mountpoints
Dump 4625
WARNING: mountpoints returned 1 and left running for debug needs
Test: zdtm/live/static/mountpoints, Result: FAIL
==================================== ERROR 
====================================
Test: zdtm/live/static/mountpoints, Namespace:
Dump log   : /root/git/xcriu/test/dump/mountpoints/4625/1/dump.log
--------------------------------- grep Error 
---------------------------------
(00.004219) Error (mount.c:449): 116:./zdtm_mpts/module doesn't have a 
proper root mount
(00.004373) Error (cr-dump.c:1914): Dumping FAILED.
------------------------------------- END 
-------------------------------------
================================= ERROR OVER 
=================================


>> On 05.09.2014 17:23, Ruslan Kuprieiev wrote:
>>> Hi!
>>>
>>> I'm trying to run "make test" on stock fedora 20 with 3.15 kernel.
>>> # make test &> test.log
>>>
>>> And it fails. Here is a tail of test.log:
>>>
>>> Execute zdtm/live/static/mountpoints
>>> ./mountpoints --pidfile=mountpoints.pid --outfile=mountpoints.out
>>> Dump 85
>>> WARNING: mountpoints returned 1 and left running for debug needs
>>> Test: zdtm/live/static/mountpoints, Result: FAIL
>>> ==================================== ERROR
>>> ====================================
>>> Test: zdtm/live/static/mountpoints, Namespace:
>>> Dump log   : /root/git/criu/test/dump/static/mountpoints/85/1/dump.log
>>> --------------------------------- grep Error
>>> ---------------------------------
>>> (00.179814) Error (mount.c:392): Two shared mounts 163, 180 have different
>>> sets of children
>>> (00.179827) Error (mount.c:395): 180:./zdtm_mpts/dev/share-1 doesn't have
>>> a proper point for 167:./zdtm_mpts/dev/share-3/test.mnt.share
>>> (00.180055) Error (cr-dump.c:1921): Dumping FAILED.
>>> ------------------------------------- END
>>> -------------------------------------
>>> ================================= ERROR OVER
>>> =================================
>>>
>>>
>>> make[3]: *** [static/mountpoints] Error 1
>>> make[3]: Leaving directory `/root/git/criu/test'
>>> make[2]: *** [zdtm] Error 2
>>> make[2]: Leaving directory `/root/git/criu/test'
>>> make[1]: *** [all] Error 2
>>> make[1]: Leaving directory `/root/git/criu/test'
>>> make: *** [test] Error 2
>>>
>>>
>>> test.log and dump.log are attached.
>>>
>>> Thanks,
>>> Ruslan