[CRIU] [PATCH 0/4] fsnotify: First step to rip off parasite fsnotify events

Andrew Vagin avagin at parallels.com
Thu Sep 4 12:34:43 PDT 2014


[root at avagin-fc19-cr criu]# bash test/zdtm.sh -i 4 static/inotify00
================================= CRIU CHECK =================================
Looks good.
Execute zdtm/live/static/inotify00
./inotify00 --pidfile=inotify00.pid --outfile=inotify00.out --dirname=inotify00.test
Dump 1733
Restore
Dump 1733
WARNING: inotify00 returned 1 and left running for debug needs
Test: zdtm/live/static/inotify00, Result: FAIL
==================================== ERROR ====================================
Test: zdtm/live/static/inotify00, Namespace: 
Dump log   : /root/git/orig/criu/test/dump/static/inotify00/1733/2/dump.log
--------------------------------- grep Error ---------------------------------
(00.021954) Error (fsnotify.c:240): fsnotify: The 3 inotify has queued events
(00.021985) Error (cr-dump.c:1576): Dump files (pid: 1733) failed with -1
(00.024109) Error (cr-dump.c:1924): Dumping FAILED.
------------------------------------- END -------------------------------------
================================= ERROR OVER =================================


On Thu, Sep 04, 2014 at 10:23:34PM +0400, Cyrill Gorcunov wrote:
> Tests revealed that we're generating own fsnotify events during c/r.
> So here is a first step to fix this situation
> 
> Cyrill Gorcunov (4):
>   fsnotify: Make open_inotify_fd and open_fanotify_fd to look similar
>   fsnotify: Flush own generated events
>   files: ghost -- Defer dumping of ghost files contents
>   files: ghost -- Implement clear_ghost_files
> 
>  cr-dump.c           |   4 ++
>  files-reg.c         | 129 ++++++++++++++++++++++++++++---------------
>  fsnotify.c          | 154 +++++++++++++++++++++++++++++++++++++++++++++-------
>  include/files-reg.h |   1 +
>  4 files changed, 224 insertions(+), 64 deletions(-)
> 
> -- 
> 1.9.3
> 


More information about the CRIU mailing list