[CRIU] [PATCH 0/3] fsnotify: Bring back "ignore queues" mode

Cyrill Gorcunov gorcunov at gmail.com
Wed Sep 3 11:22:04 PDT 2014


On Wed, Sep 03, 2014 at 10:15:04PM +0400, Pavel Emelyanov wrote:
> On 09/03/2014 10:06 PM, Cyrill Gorcunov wrote:
> > Let a user to deside which mode to work with -- refuse to proceed
> > if there is queued fsnotify data, or pass ignoring them. By default
> > ignore them as we were since first fsnotify implementation.
> 
> NAK. We did it wrong, now we've fixed it. And test fails simply
> because _it_ generates the events. Just flush the events in the
> test.

Sigh. Look, the problem is more deeper. Have someone tested new model
with real lcx/docker container? I like the idea to refuse dumping until
queue is empty but otoh I believe we should give users an option to
disable such behaviour. What if there will be some fanotify over
root partition with generates events again and again, does it mean
we should simply not be able to dump such application?


More information about the CRIU mailing list