[CRIU] [PATCH] zdtm/inotify00: check events properly

[Pavel Emelyanov]

On 09/02/2014 12:17 PM, Cyrill Gorcunov wrote:
> On Tue, Sep 02, 2014 at 12:01:51AM +0400, Andrey Vagin wrote:
>> Now test catches smth. Cyrill, could you look at this:
>>
>> [root at avagin-fc19-cr criu]# bash test/zdtm.sh -i 1  static/inotify00
>> ================================= CRIU CHECK =================================
>> Error (timerfd.c:56): timerfd: No timerfd support for c/r: Inappropriate ioctl for device
>> ============================= WARNING =============================
>> Not all features needed for CRIU are merged to upstream kernel yet,
>> so for now we maintain our own branch which can be cloned from:
>> git://git.kernel.org/pub/scm/linux/kernel/git/gorcunov/linux-cr.git
>> ===================================================================
>> Execute zdtm/live/static/inotify00
>> ./inotify00 --pidfile=inotify00.pid --outfile=inotify00.out
>>
>> Dump 9184
>> Restore
>> Check results 9184
>> Test: zdtm/live/static/inotify00, Result: FAIL
>> ==================================== ERROR ====================================
>> Test: zdtm/live/static/inotify00, Namespace:
>> Dump log   : /root/git/orig/criu/test/dump/static/inotify00/9184/1/dump.log
>> --------------------------------- grep Error ---------------------------------
>> ------------------------------------- END -------------------------------------
>> Restore log: /root/git/orig/criu/test/dump/static/inotify00/9184/1/restore.log
>> --------------------------------- grep Error ---------------------------------
>> ------------------------------------- END -------------------------------------
>> Output file: /root/git/orig/criu/test/zdtm/live/static/inotify00.out
>> ------------------------------------------------------------------------------
>> 23:38:37.709:  9184: 4
>> 23:38:37.709:  9184: -----
>> 23:38:38.902:  9184: 10
>> 23:38:38.903:  9184: 4
>> 23:38:38.903:  9184: 20
>> 23:38:38.903:  9184: 4
>> 23:38:38.903:  9184: 400
>> 23:38:38.903:  9184: 8000
>> 23:38:38.903:  9184: FAIL: inotify00.c:90: Unexpected events (errno = 11 (Resource temporarily unavailable))
>> 23:38:38.903:  9184: -----
>> ------------------------------------- END -------------------------------------
>> ================================= ERROR OVER =================================
>>
>> Cc: Cyrill Gorcunov <gorcunov at openvz.org>
>> Signed-off-by: Andrey Vagin <avagin at openvz.org>
> Acked-by: Cyrill Gorcunov <gorcunov at openvz.org>

Thanks, but AFAIU I can't merge this yet since, as Cyrill says,
CRIU still generates events. Am I right?

> Pavel, mind to merge Andrew's fixes for fsnotify code
> so I would work on restore of deleted files thus criu
> won't generate own event then.
> .
>