[CRIU] [PATCH 6/6] cpuinfo: x86 -- Add dump and validation

[Pavel Emelyanov]

On 09/01/2014 01:06 PM, Cyrill Gorcunov wrote:

> diff --git a/cr-dump.c b/cr-dump.c
> index cec579ead5be..ef16432dc2d4 100644
> --- a/cr-dump.c
> +++ b/cr-dump.c
> @@ -1816,6 +1816,9 @@ int cr_dump_tasks(pid_t pid)
>  	if (write_img_inventory())
>  		goto err;
>  
> +	if (cpu_dump_cpuinfo())
> +		goto err;
> +

I really doubt CRIU should do it this way. When we live-migrate
container we first may do long FS sync, then we start iterations
which might take time. If at the time of dump we find out, that
we have CPU mismatch in source-vs-destination it will be ...
disappointing.

I would suggest implementing it in the way OpenVZ migration does.
Before we start live migration we should check whether the migration
is possible at all and only then start messing with CRIU. I don't
mind CRIU helping it though.

>  	if (connect_to_page_server())
>  		goto err;
>  

Thanks,
Pavel